Re: [PATCH RFC 1/3] target/arm: Implement SVE2 AESMC, AESIMC

[Richard Henderson]

On 4/23/20 3:37 PM, Stephen Long wrote:
> +#define DO_CRYPTO_AESMC(NAME, DECRYPT)                          \
> +void HELPER(NAME)(void *vd, void *vn, uint32_t desc)            \
> +{                                                               \
> +    intptr_t i, opr_sz = simd_oprsz(desc);                      \
> +    void *d = vd, *n = vn;                                      \
> +    for (i = 0; i < opr_sz; i += 16) {                          \
> +        HELPER(crypto_aesmc)(vd + i, vn + i, DECRYPT);          \
> +    }
> +}

Better, IMO, is to add a "desc" parameter to crypto_aesmc and move the loop
there.  Then all variants of this operation use the exact same helper.  The
separate decrypt parameter would become simd_data().

Same for the other two patches in this series.


r~