Re: [PATCH v2 14/15] qapi: Disallow qmp_marshal_FOO(NULL, ...)

[Eric Blake]

On 4/24/20 3:43 AM, Markus Armbruster wrote:
> For QMP commands without arguments, gen_marshal() laboriously
> generates a qmp_marshal_FOO() that copes with null @args.  Turns
> there's just one caller that passes null instead of an empty QDict.
> Adjust that caller, and simplify gen_marshal().
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   docs/devel/qapi-code-gen.txt |  2 +-
>   monitor/qmp.c                |  5 ++++-
>   scripts/qapi/commands.py     | 26 ++------------------------
>   3 files changed, 7 insertions(+), 26 deletions(-)

Fun diffstat.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org