Re: [PATCH RESEND v6 08/36] multi-process: Add stub functions to facilitate build of multi-process

[Stefan Hajnoczi]

On Wed, Apr 22, 2020 at 09:13:43PM -0700, address@hidden wrote:
> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
> index f884bb6180..f74c7e927b 100644
> --- a/stubs/Makefile.objs
> +++ b/stubs/Makefile.objs
> @@ -20,6 +20,7 @@ stub-obj-y += migr-blocker.o
>  stub-obj-y += change-state-handler.o
>  stub-obj-y += monitor.o
>  stub-obj-y += monitor-core.o
> +stub-obj-y += get-fd.o
>  stub-obj-y += notify-event.o
>  stub-obj-y += qtest.o
>  stub-obj-y += replay.o

audio.c, vl-stub.c, and xen-mapcache.c are added by this patch but not
added to Makefile.objs?  Can they be removed?

This entire patch requires justification.  Stubs exist so that common
code can be linked without optional features.

For example, common code may call into kvm but that callback isn't
relevant when building with kvm accelerator support (e.g. say qemu-nbd).
That's where the stub function comes in.  It fulfills the dependency
without dragging in the actual kvm accelerator code.

Adding lots of stubs suggests you are building QEMU in a new way that
wasn't done before (this is true and expected for this patch series).  I
would like to understand the reason for these stubs though.  For
example, why do you need to stub audio?

Without a reason for each of these stubs we have no way of knowing if
they are actually used/needed.  Maybe an earlier version of the code
needed it but the latest version of the patch no longer does...

Stefan

signature.asc
Description: PGP signature