Re: [PATCH RESEND v6 00/36] Initial support for multi-process qemu

[Daniel P . Berrangé]

On Fri, Apr 24, 2020 at 01:48:23PM +0100, Stefan Hajnoczi wrote:
> On Wed, Apr 22, 2020 at 09:13:35PM -0700, address@hidden wrote:
> > There is an error in travis-ci build test which does not get reproduced.
> > 
> >  TEST    iotest-qcow2: 041 [fail]
> > QEMU          -- 
> > "/home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64"
> >  -nodefaults -display none -accel qtest
> > QEMU_IMG      -- 
> > "/home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/../../qemu-img"
> >  
> > QEMU_IO       -- 
> > "/home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/../../qemu-io"
> >   --cache writeback --aio threads -f qcow2
> > QEMU_NBD      -- 
> > "/home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/../../qemu-nbd"
> >  
> > IMGFMT        -- qcow2 (compat=1.1)
> > IMGPROTO      -- file
> > PLATFORM      -- Linux/x86_64 
> > travis-job-fc4e2553-b470-4a8b-812e-a4fcf8ba094f 5.0.0-1031-gcp
> > TEST_DIR      -- 
> > /home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/scratch
> > SOCK_DIR      -- /tmp/tmp.LOmYANt5Od
> > SOCKET_SCM_HELPER -- 
> > /home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/socket_scm_helper
> > --- 
> > /home/travis/build/elena-ufimtseva/qemu-multiprocess/tests/qemu-iotests/041.out
> >  2020-04-22 00:17:23.701844698 +0000
> > +++ 
> > /home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/041.out.bad
> >        2020-04-22 00:24:39.234343858 +0000
> > @@ -1,5 +1,29 @@
> > -..............................................................................................
> > +........................FF....................................................................
> > +======================================================================
> > +FAIL: test_with_other_parent (__main__.TestRepairQuorum)
> > +----------------------------------------------------------------------
> > +Traceback (most recent call last):
> > +  File "041", line 1049, in test_with_other_parent
> > +    self.assert_qmp(result, 'return', {})
> > +  File 
> > "/home/travis/build/elena-ufimtseva/qemu-multiprocess/tests/qemu-iotests/iotests.py",
> >  line 821, in assert_qmp
> > +    result = self.dictpath(d, path)
> > +  File 
> > "/home/travis/build/elena-ufimtseva/qemu-multiprocess/tests/qemu-iotests/iotests.py",
> >  line 797, in dictpath
> > +    self.fail('failed path traversal for "%s" in "%s"' % (path, str(d)))
> > +AssertionError: failed path traversal for "return" in "{'error': {'class': 
> > 'GenericError', 'desc': "UNIX socket path 
> > '/home/travis/build/elena-ufimtseva/qemu-multiprocess/out-of-tree/build/dir/tests/qemu-iotests/scratch/nbd.sock'
> >  is too long"}}"
> 
> UNIX Domain Socket paths have to be 108 characters or less.  The path in
> the failed test case is 110 characters long.  You could rename your
> branch to "mpqemu" to solve this failure.

Renaming is a pretty poor band-aid.

We should fix the i/o tests instead, so that they use a scratch dir under
$TMP to store unix sockets needed by tests instead.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|