[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] block: Add blk_new_with_bs() helper
From: |
Max Reitz |
Subject: |
Re: [PATCH v2 1/3] block: Add blk_new_with_bs() helper |
Date: |
Fri, 24 Apr 2020 12:02:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 24.04.20 11:56, Max Reitz wrote:
> On 24.04.20 11:53, Max Reitz wrote:
>> On 24.04.20 00:17, Eric Blake wrote:
>>> There are several callers that need to create a new block backend from
>>> an existing BDS; make the task slightly easier with a common helper
>>> routine.
>>>
>>> Suggested-by: Max Reitz <address@hidden>
>>> Signed-off-by: Eric Blake <address@hidden>
>>> ---
>>> include/sysemu/block-backend.h | 2 ++
>>> block/block-backend.c | 23 +++++++++++++++++++++++
>>> block/crypto.c | 8 +++-----
>>> block/parallels.c | 7 +++----
>>> block/qcow.c | 7 +++----
>>> block/qcow2.c | 15 ++++++---------
>>> block/qed.c | 7 +++----
>>> block/sheepdog.c | 9 ++++-----
>>> block/vdi.c | 7 +++----
>>> block/vhdx.c | 7 +++----
>>> block/vmdk.c | 9 ++++-----
>>> block/vpc.c | 7 +++----
>>> blockdev.c | 8 +++-----
>>> blockjob.c | 7 ++-----
>>> 14 files changed, 65 insertions(+), 58 deletions(-)
>>
>> Reviewed-by: Max Reitz <address@hidden>
>
> (With the Patchew warning fixed, of course (i.e., we should set ret to
> -EPERM or something in qcow.c))
Er, well, maybe I should have looked into more places. The compiler
only warns about that single one because it’s the only place where @ret
is really uninitialized, but there are many more where we need to set
it: crypto.c, parallels.c, qcow.c, qcow2.c (both hunks), qed.c,
sheepdog.c, vdi.c, vhdx.c, and vpc.c.
(So basically everywhere but vmdk.c, blockdev.c, and blockjob.c.)
And now I’m going to get another coffee...
Max
signature.asc
Description: OpenPGP digital signature
Re: [PATCH v2 1/3] block: Add blk_new_with_bs() helper, Stefan Hajnoczi, 2020/04/24
[PATCH v2 2/3] qcow2: Allow resize of images with internal snapshots, Eric Blake, 2020/04/23
Re: [PATCH v2 0/3] qcow2: Allow resize of images with internal snapshots, no-reply, 2020/04/23
Re: [PATCH v2 0/3] qcow2: Allow resize of images with internal snapshots, no-reply, 2020/04/23
Re: [PATCH v2 0/3] qcow2: Allow resize of images with internal snapshots, no-reply, 2020/04/23