Re: [PATCH 05/13] qapi: Polish prose in visitor.h

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/13] qapi: Polish prose in visitor.h

From:	Eric Blake
Subject:	Re: [PATCH 05/13] qapi: Polish prose in visitor.h
Date:	Thu, 23 Apr 2020 12:51:37 -0500
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

On 4/23/20 11:00 AM, Markus Armbruster wrote:

Signed-off-by: Markus Armbruster <address@hidden>
---
  include/qapi/visitor.h | 104 +++++++++++++++++++++--------------------
  1 file changed, 54 insertions(+), 50 deletions(-)


Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 04/13] qapi: Document @errp usage more thoroughly in visitor.h, (continued)
- [PATCH 03/13] qapi: Fix typo in visit_start_list()'s contract, Markus Armbruster, 2020/04/23
  - Re: [PATCH 03/13] qapi: Fix typo in visit_start_list()'s contract, Eric Blake, 2020/04/23
- [PATCH 08/13] qapi: Assert output visitors see only valid enum values, Markus Armbruster, 2020/04/23
  - Re: [PATCH 08/13] qapi: Assert output visitors see only valid enum values, Eric Blake, 2020/04/23
- [PATCH 13/13] qom: Simplify object_property_get_enum(), Markus Armbruster, 2020/04/23
  - Re: [PATCH 13/13] qom: Simplify object_property_get_enum(), Eric Blake, 2020/04/23
- [PATCH 11/13] qapi: Assert non-input visitors see only valid alternate tags, Markus Armbruster, 2020/04/23
  - Re: [PATCH 11/13] qapi: Assert non-input visitors see only valid alternate tags, Eric Blake, 2020/04/23
- [PATCH 05/13] qapi: Polish prose in visitor.h, Markus Armbruster, 2020/04/23
  - Re: [PATCH 05/13] qapi: Polish prose in visitor.h, Eric Blake <=
- [PATCH 12/13] qapi: Only input visitors can actually fail, Markus Armbruster, 2020/04/23
  - Re: [PATCH 12/13] qapi: Only input visitors can actually fail, Eric Blake, 2020/04/23
- [PATCH 09/13] qapi: Assert non-input visitors see only valid narrow integers, Markus Armbruster, 2020/04/23
  - Re: [PATCH 09/13] qapi: Assert non-input visitors see only valid narrow integers, Eric Blake, 2020/04/23
- [PATCH 02/13] qapi: Fix the virtual walk example in visitor.h's big comment, Markus Armbruster, 2020/04/23
  - Re: [PATCH 02/13] qapi: Fix the virtual walk example in visitor.h's big comment, Eric Blake, 2020/04/23
- [PATCH 07/13] qapi: Fix Visitor contract for start_alternate(), Markus Armbruster, 2020/04/23
  - Re: [PATCH 07/13] qapi: Fix Visitor contract for start_alternate(), Eric Blake, 2020/04/23

Prev by Date: Re: [PATCH 0/5] QEMU Gating CI
Next by Date: Re: [PATCH 06/13] qapi: Assert incomplete object occurs only in dealloc visitor
Previous by thread: [PATCH 05/13] qapi: Polish prose in visitor.h
Next by thread: [PATCH 12/13] qapi: Only input visitors can actually fail
Index(es):
- Date
- Thread