[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RESEND v6 06/36] monitor: destaticize HMP commands
From: |
Jag Raman |
Subject: |
Re: [PATCH RESEND v6 06/36] monitor: destaticize HMP commands |
Date: |
Thu, 23 Apr 2020 11:07:50 -0400 |
> On Apr 23, 2020, at 10:14 AM, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Why 'destaticize HMP commands’?
Hi Philippe,
Both QEMU & the remote process links the QMP code. QEMU uses
all of the QMP commands, whereas, the remote process only uses a
subset of this. Therefore, the ‘static’ functions which don’t have a
reference cause build errors (like defined but not used). Therefore,
we decided to destaticize the ones that are causing the build failure.
On a different note, Dave had previously suggested destacizing only the
HMP functions used by the remote process. However, we found out that this is
not possible because without all these functions, the build error still
reproduces.
We did confirm that all the functions we have destaticized are necessary to
help with build of the remote process.
Thank you very much!
--
Jag
>
> On 4/23/20 6:13 AM, address@hidden wrote:
>> From: Jagannathan Raman <address@hidden>
>> Signed-off-by: Elena Ufimtseva <address@hidden>
>> Signed-off-by: John G Johnson <address@hidden>
>> Signed-off-by: Jagannathan Raman <address@hidden>
>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>> ---
>> hmp-commands.hx | 4 +-
>> monitor/misc.c | 76 +++++++++++++++++++-------------------
>> monitor/monitor-internal.h | 38 +++++++++++++++++++
>> 3 files changed, 78 insertions(+), 40 deletions(-)
>
- [PATCH RESEND v6 00/36] Initial support for multi-process qemu, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 04/36] multi-process: Refactor chardev functions out of vl.c, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 03/36] command-line: refractor parser code, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 05/36] multi-process: Refactor monitor functions out of vl.c, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 01/36] memory: alloc RAM from file at offset, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 06/36] monitor: destaticize HMP commands, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 09/36] multi-process: Add config option for multi-process QEMU, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 07/36] multi-process: add a command line option for debug file, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 13/36] multi-process: setup PCI host bridge for remote device, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 15/36] multi-process: setup memory manager for remote device, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 16/36] multi-process: remote process initialization, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 18/36] multi-process: Initialize Proxy Object's communication channel, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 19/36] multi-process: Connect Proxy Object with device in the remote process, elena . ufimtseva, 2020/04/23
- [PATCH RESEND v6 21/36] multi-process: PCI BAR read/write handling for proxy & remote endpoints, elena . ufimtseva, 2020/04/23