Re: [PATCH v2 00/14] Miscellaneous error handling fixes

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 00/14] Miscellaneous error handling fixes
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
dd69af1 qga: Fix qmp_guest_suspend_{disk, ram}() error handling
4a08f31 qga: Fix qmp_guest_get_memory_blocks() error handling
637065b tests/test-logging: Fix test for -dfilter 0..0xffffffffffffffff
373e741 migration/colo: Fix qmp_xen_colo_do_checkpoint() error handling
aee8384 io: Fix qio_channel_socket_close() error handling
d6149e9 xen/pt: Fix flawed conversion to realize()
698866e virtio-net: Fix duplex=... and speed=... error handling
ead7d5b bochs-display: Fix vgamem=SIZE error handling
e36a75a fdc: Fix fallback=auto error handling
3840993 arm/virt: Fix virt_machine_device_plug_cb() error API violation
e673dde cpus: Proper range-checking for -icount shift=N
ec03bd5 cpus: Fix configure_icount() error API violation
b7227e5 block/file-posix: Fix check_cache_dropped() error handling
c2d6383 cryptodev: Fix cryptodev_builtin_cleanup() error API violation

=== OUTPUT BEGIN ===
1/14 Checking commit c2d63831898d (cryptodev: Fix cryptodev_builtin_cleanup() 
error API violation)
2/14 Checking commit b7227e54d3e2 (block/file-posix: Fix check_cache_dropped() 
error handling)
3/14 Checking commit ec03bd56477a (cpus: Fix configure_icount() error API 
violation)
ERROR: consider using qemu_strtol in preference to strtol
#58: FILE: cpus.c:818:
+        time_shift = strtol(option, &rem_str, 0);

total: 1 errors, 0 warnings, 70 lines checked

Patch 3/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/14 Checking commit e673dde157bc (cpus: Proper range-checking for -icount 
shift=N)
5/14 Checking commit 384099345bd0 (arm/virt: Fix virt_machine_device_plug_cb() 
error API violation)
6/14 Checking commit e36a75a34539 (fdc: Fix fallback=auto error handling)
7/14 Checking commit ead7d5bb1f48 (bochs-display: Fix vgamem=SIZE error 
handling)
8/14 Checking commit 698866e34497 (virtio-net: Fix duplex=... and speed=... 
error handling)
9/14 Checking commit d6149e9c741d (xen/pt: Fix flawed conversion to realize())
10/14 Checking commit aee83842a8dc (io: Fix qio_channel_socket_close() error 
handling)
11/14 Checking commit 373e741c45db (migration/colo: Fix 
qmp_xen_colo_do_checkpoint() error handling)
12/14 Checking commit 637065bdb8fe (tests/test-logging: Fix test for -dfilter 
0..0xffffffffffffffff)
13/14 Checking commit 4a08f313759b (qga: Fix qmp_guest_get_memory_blocks() 
error handling)
14/14 Checking commit dd69af1d8010 (qga: Fix qmp_guest_suspend_{disk, ram}() 
error handling)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden