Re: [PATCH 2/2] crypto/secret: fix return logic of crypto_secret_prop_get_loaded()

[Daniel P . Berrangé]

On Wed, Apr 15, 2020 at 11:13:36PM +0300, Alexey Krasikov wrote:
> * Get function returned value of properties 'data' insteed of returning
>   value of raw data internal field. This error did not affect anyone,
>   because no one called the get function.
> 
> Signed-off-by: Alexey Krasikov <address@hidden>
> ---
>  crypto/secret.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/secret.c b/crypto/secret.c
> index 546b965afe..79b9b4ce0c 100644
> --- a/crypto/secret.c
> +++ b/crypto/secret.c
> @@ -231,7 +231,7 @@ qcrypto_secret_prop_get_loaded(Object *obj,
>                                 Error **errp G_GNUC_UNUSED)
>  {
>      QCryptoSecret *secret = QCRYPTO_SECRET(obj);
> -    return secret->data != NULL;
> +    return secret->rawdata != NULL;
>  }

I already have this change queued from another user, so I'll drop this
dupe.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|