qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/5] ramfb: drop leftover debug message


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 5/5] ramfb: drop leftover debug message
Date: Wed, 22 Apr 2020 12:26:39 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 4/22/20 12:02 PM, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann <address@hidden>
---
  hw/display/ramfb.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c
index d1b1cb9bb294..be884c9ea837 100644
--- a/hw/display/ramfb.c
+++ b/hw/display/ramfb.c
@@ -88,8 +88,6 @@ static void ramfb_fw_cfg_write(void *dev, off_t offset, 
size_t len)
      addr   = be64_to_cpu(s->cfg.addr);
      format = qemu_drm_format_to_pixman(fourcc);
- fprintf(stderr, "%s: %dx%d @ 0x%" PRIx64 "\n", __func__,
-            s->width, s->height, addr);
      surface = ramfb_create_display_surface(width, height,
                                             format, stride, addr);
      if (!surface)


I'd move this before patch #3/5 "ramfb: don't update RAMFBState on errors". Anyway,

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]