qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] hax: Fix setting of FD_CLOEXEC


From: Colin Xu
Subject: Re: [PATCH 1/2] hax: Fix setting of FD_CLOEXEC
Date: Tue, 21 Apr 2020 09:22:15 +0800 (CST)
User-agent: Alpine 2.22 (LNX 419 2020-04-12)

Looks good to me.

Reviewed-by: Colin Xu <address@hidden>

--
Best Regards,
Colin Xu

On Tue, 21 Apr 2020, Eric Blake wrote:

Blindly setting FD_CLOEXEC without a read-modify-write will
inadvertently clear any other intentionally-set bits, such as a
proposed new bit for designating a fd that must behave in 32-bit mode.
Use our wrapper function instead of an incorrect hand-rolled version.

Signed-off-by: Eric Blake <address@hidden>
---
target/i386/hax-posix.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/i386/hax-posix.c b/target/i386/hax-posix.c
index 3bad89f13337..5f9d1b803dec 100644
--- a/target/i386/hax-posix.c
+++ b/target/i386/hax-posix.c
@@ -23,7 +23,7 @@ hax_fd hax_mod_open(void)
        fprintf(stderr, "Failed to open the hax module\n");
    }

-    fcntl(fd, F_SETFD, FD_CLOEXEC);
+    qemu_set_cloexec(fd);

    return fd;
}
@@ -147,7 +147,7 @@ hax_fd hax_host_open_vm(struct hax_state *hax, int vm_id)
    fd = open(vm_name, O_RDWR);
    g_free(vm_name);

-    fcntl(fd, F_SETFD, FD_CLOEXEC);
+    qemu_set_cloexec(fd);

    return fd;
}
@@ -200,7 +200,7 @@ hax_fd hax_host_open_vcpu(int vmid, int vcpuid)
    if (fd < 0) {
        fprintf(stderr, "Failed to open the vcpu devfs\n");
    }
-    fcntl(fd, F_SETFD, FD_CLOEXEC);
+    qemu_set_cloexec(fd);
    return fd;
}

--
2.26.1





reply via email to

[Prev in Thread] Current Thread [Next in Thread]