Re: [PATCH 6/7] tcg: Remove tcg_gen_gvec_dup{8,16,32,64}i

[David Hildenbrand]

On 18.04.20 17:04, Richard Henderson wrote:
> These interfaces are now unused.
> 
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  include/tcg/tcg-op-gvec.h |  5 -----
>  tcg/tcg-op-gvec.c         | 28 ----------------------------
>  2 files changed, 33 deletions(-)
> 
> diff --git a/include/tcg/tcg-op-gvec.h b/include/tcg/tcg-op-gvec.h
> index eb0d47a42b..fa8a0c8d03 100644
> --- a/include/tcg/tcg-op-gvec.h
> +++ b/include/tcg/tcg-op-gvec.h
> @@ -320,11 +320,6 @@ void tcg_gen_gvec_dup_i32(unsigned vece, uint32_t dofs, 
> uint32_t s,
>  void tcg_gen_gvec_dup_i64(unsigned vece, uint32_t dofs, uint32_t s,
>                            uint32_t m, TCGv_i64);
>  
> -void tcg_gen_gvec_dup8i(uint32_t dofs, uint32_t s, uint32_t m, uint8_t x);
> -void tcg_gen_gvec_dup16i(uint32_t dofs, uint32_t s, uint32_t m, uint16_t x);
> -void tcg_gen_gvec_dup32i(uint32_t dofs, uint32_t s, uint32_t m, uint32_t x);
> -void tcg_gen_gvec_dup64i(uint32_t dofs, uint32_t s, uint32_t m, uint64_t x);
> -
>  void tcg_gen_gvec_shli(unsigned vece, uint32_t dofs, uint32_t aofs,
>                         int64_t shift, uint32_t oprsz, uint32_t maxsz);
>  void tcg_gen_gvec_shri(unsigned vece, uint32_t dofs, uint32_t aofs,
> diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c
> index de16c027b3..5a6cc19812 100644
> --- a/tcg/tcg-op-gvec.c
> +++ b/tcg/tcg-op-gvec.c
> @@ -1541,34 +1541,6 @@ void tcg_gen_gvec_dup_mem(unsigned vece, uint32_t 
> dofs, uint32_t aofs,
>      }
>  }
>  
> -void tcg_gen_gvec_dup64i(uint32_t dofs, uint32_t oprsz,
> -                         uint32_t maxsz, uint64_t x)
> -{
> -    check_size_align(oprsz, maxsz, dofs);
> -    do_dup(MO_64, dofs, oprsz, maxsz, NULL, NULL, x);
> -}
> -
> -void tcg_gen_gvec_dup32i(uint32_t dofs, uint32_t oprsz,
> -                         uint32_t maxsz, uint32_t x)
> -{
> -    check_size_align(oprsz, maxsz, dofs);
> -    do_dup(MO_32, dofs, oprsz, maxsz, NULL, NULL, x);
> -}
> -
> -void tcg_gen_gvec_dup16i(uint32_t dofs, uint32_t oprsz,
> -                         uint32_t maxsz, uint16_t x)
> -{
> -    check_size_align(oprsz, maxsz, dofs);
> -    do_dup(MO_16, dofs, oprsz, maxsz, NULL, NULL, x);
> -}
> -
> -void tcg_gen_gvec_dup8i(uint32_t dofs, uint32_t oprsz,
> -                         uint32_t maxsz, uint8_t x)
> -{
> -    check_size_align(oprsz, maxsz, dofs);
> -    do_dup(MO_8, dofs, oprsz, maxsz, NULL, NULL, x);
> -}
> -
>  void tcg_gen_gvec_dup_imm(unsigned vece, uint32_t dofs, uint32_t oprsz,
>                            uint32_t maxsz, uint64_t x)
>  {
> 

Reviewed-by: David Hildenbrand <address@hidden>

-- 
Thanks,

David / dhildenb