[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/16] tcg: Rename struct tcg_temp_info to TempOptInfo
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 07/16] tcg: Rename struct tcg_temp_info to TempOptInfo |
Date: |
Mon, 20 Apr 2020 09:00:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 4/18/20 6:19 PM, Richard Henderson wrote:
> Fix this name vs our coding style.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tcg/optimize.c | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index effb47eefd..b86bf3d707 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -35,20 +35,20 @@
> glue(glue(case INDEX_op_, x), _i64): \
> glue(glue(case INDEX_op_, x), _vec)
>
> -struct tcg_temp_info {
> +typedef struct TempOptInfo {
> bool is_const;
> TCGTemp *prev_copy;
> TCGTemp *next_copy;
> tcg_target_ulong val;
> tcg_target_ulong mask;
> -};
> +} TempOptInfo;
>
> -static inline struct tcg_temp_info *ts_info(TCGTemp *ts)
> +static inline TempOptInfo *ts_info(TCGTemp *ts)
> {
> return ts->state_ptr;
> }
>
> -static inline struct tcg_temp_info *arg_info(TCGArg arg)
> +static inline TempOptInfo *arg_info(TCGArg arg)
> {
> return ts_info(arg_temp(arg));
> }
> @@ -71,9 +71,9 @@ static inline bool ts_is_copy(TCGTemp *ts)
> /* Reset TEMP's state, possibly removing the temp for the list of copies. */
> static void reset_ts(TCGTemp *ts)
> {
> - struct tcg_temp_info *ti = ts_info(ts);
> - struct tcg_temp_info *pi = ts_info(ti->prev_copy);
> - struct tcg_temp_info *ni = ts_info(ti->next_copy);
> + TempOptInfo *ti = ts_info(ts);
> + TempOptInfo *pi = ts_info(ti->prev_copy);
> + TempOptInfo *ni = ts_info(ti->next_copy);
>
> ni->prev_copy = ti->prev_copy;
> pi->next_copy = ti->next_copy;
> @@ -89,12 +89,12 @@ static void reset_temp(TCGArg arg)
> }
>
> /* Initialize and activate a temporary. */
> -static void init_ts_info(struct tcg_temp_info *infos,
> +static void init_ts_info(TempOptInfo *infos,
> TCGTempSet *temps_used, TCGTemp *ts)
> {
> size_t idx = temp_idx(ts);
> if (!test_bit(idx, temps_used->l)) {
> - struct tcg_temp_info *ti = &infos[idx];
> + TempOptInfo *ti = &infos[idx];
>
> ts->state_ptr = ti;
> ti->next_copy = ts;
> @@ -114,7 +114,7 @@ static void init_ts_info(struct tcg_temp_info *infos,
> }
> }
>
> -static void init_arg_info(struct tcg_temp_info *infos,
> +static void init_arg_info(TempOptInfo *infos,
> TCGTempSet *temps_used, TCGArg arg)
> {
> init_ts_info(infos, temps_used, arg_temp(arg));
> @@ -177,7 +177,7 @@ static void tcg_opt_gen_movi(TCGContext *s, TCGOp *op,
> TCGArg dst, TCGArg val)
> const TCGOpDef *def;
> TCGOpcode new_op;
> tcg_target_ulong mask;
> - struct tcg_temp_info *di = arg_info(dst);
> + TempOptInfo *di = arg_info(dst);
>
> def = &tcg_op_defs[op->opc];
> if (def->flags & TCG_OPF_VECTOR) {
> @@ -208,8 +208,8 @@ static void tcg_opt_gen_mov(TCGContext *s, TCGOp *op,
> TCGArg dst, TCGArg src)
> TCGTemp *dst_ts = arg_temp(dst);
> TCGTemp *src_ts = arg_temp(src);
> const TCGOpDef *def;
> - struct tcg_temp_info *di;
> - struct tcg_temp_info *si;
> + TempOptInfo *di;
> + TempOptInfo *si;
> tcg_target_ulong mask;
> TCGOpcode new_op;
>
> @@ -242,7 +242,7 @@ static void tcg_opt_gen_mov(TCGContext *s, TCGOp *op,
> TCGArg dst, TCGArg src)
> di->mask = mask;
>
> if (src_ts->type == dst_ts->type) {
> - struct tcg_temp_info *ni = ts_info(si->next_copy);
> + TempOptInfo *ni = ts_info(si->next_copy);
>
> di->next_copy = si->next_copy;
> di->prev_copy = src_ts;
> @@ -605,7 +605,7 @@ void tcg_optimize(TCGContext *s)
> {
> int nb_temps, nb_globals;
> TCGOp *op, *op_next, *prev_mb = NULL;
> - struct tcg_temp_info *infos;
> + TempOptInfo *infos;
> TCGTempSet temps_used;
>
> /* Array VALS has an element for each temp.
> @@ -616,7 +616,7 @@ void tcg_optimize(TCGContext *s)
> nb_temps = s->nb_temps;
> nb_globals = s->nb_globals;
> bitmap_zero(temps_used.l, nb_temps);
> - infos = tcg_malloc(sizeof(struct tcg_temp_info) * nb_temps);
> + infos = tcg_malloc(sizeof(TempOptInfo) * nb_temps);
>
> QTAILQ_FOREACH_SAFE(op, &s->ops, link, op_next) {
> tcg_target_ulong mask, partmask, affected;
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- [PATCH 00/16] tcg: Better handling of constants, Richard Henderson, 2020/04/18
- [PATCH 01/16] tcg: Add temp_readonly, Richard Henderson, 2020/04/18
- [PATCH 05/16] tcg: Use tcg_constant_{i32,vec} with tcg vec expanders, Richard Henderson, 2020/04/18
- [PATCH 02/16] tcg: Introduce TYPE_CONST temporaries, Richard Henderson, 2020/04/18
- [PATCH 03/16] tcg: Use tcg_constant_i32 with icount expander, Richard Henderson, 2020/04/18
- [PATCH 06/16] tcg: Use tcg_constant_{i32,i64} with tcg plugins, Richard Henderson, 2020/04/18
- [PATCH 07/16] tcg: Rename struct tcg_temp_info to TempOptInfo, Richard Henderson, 2020/04/18
- Re: [PATCH 07/16] tcg: Rename struct tcg_temp_info to TempOptInfo,
Philippe Mathieu-Daudé <=
- [PATCH 08/16] tcg/optimize: Adjust TempOptInfo allocation, Richard Henderson, 2020/04/18
- [PATCH 04/16] tcg: Use tcg_constant_{i32,i64} with tcg int expanders, Richard Henderson, 2020/04/18
- [PATCH 10/16] tcg/tci: Add special tci_movi_{i32,i64} opcodes, Richard Henderson, 2020/04/18
- [PATCH 09/16] tcg/optimize: Use tcg_constant_internal with constant folding, Richard Henderson, 2020/04/18
- [PATCH 12/16] tcg: Use tcg_out_dupi_vec from temp_load, Richard Henderson, 2020/04/18
- [PATCH 14/16] tcg: Add tcg_reg_alloc_dup2, Richard Henderson, 2020/04/18
- [PATCH 13/16] tcg: Increase tcg_out_dupi_vec immediate to int64_t, Richard Henderson, 2020/04/18
- [PATCH 11/16] tcg: Remove movi and dupi opcodes, Richard Henderson, 2020/04/18
- [PATCH 16/16] tcg: Remove tcg_gen_dup{8,16,32,64}i_vec, Richard Henderson, 2020/04/18
- [PATCH 15/16] tcg/i386: Use tcg_constant_vec with tcg vec expanders, Richard Henderson, 2020/04/18