[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/16] nvme: refactoring and cleanups
From: |
Klaus Birkelund Jensen |
Subject: |
Re: [PATCH v2 00/16] nvme: refactoring and cleanups |
Date: |
Mon, 20 Apr 2020 07:14:11 +0200 |
On Apr 15 15:01, Klaus Jensen wrote:
> From: Klaus Jensen <address@hidden>
>
> Changes since v1
> ~~~~~~~~~~~~~~~~
> * nvme: fix pci doorbell size calculation
> - added some defines and a better comment (Philippe)
>
> * nvme: rename trace events to pci_nvme
> - changed the prefix from nvme_dev to pci_nvme (Philippe)
>
> * nvme: add max_ioqpairs device parameter
> - added a deprecation comment. I doubt this will go in until 5.1, so
> changed it to "deprecated from 5.1" (Philippe)
>
> * nvme: factor out property/constraint checks
> * nvme: factor out block backend setup
> - changed to return void and propagate errors in proper QEMU style
> (Philippe)
>
> * nvme: add namespace helpers
> - use the helper immediately (Philippe)
>
> * nvme: factor out pci setup
> - removed setting of vendor and device id which is already inherited
> from nvme_class_init() (Philippe)
>
> * nvme: factor out cmb setup
> - add lost comment (Philippe)
>
>
> Klaus Jensen (16):
> nvme: fix pci doorbell size calculation
> nvme: rename trace events to pci_nvme
> nvme: remove superfluous breaks
> nvme: move device parameters to separate struct
> nvme: use constants in identify
> nvme: refactor nvme_addr_read
> nvme: add max_ioqpairs device parameter
> nvme: remove redundant cmbloc/cmbsz members
> nvme: factor out property/constraint checks
> nvme: factor out device state setup
> nvme: factor out block backend setup
> nvme: add namespace helpers
> nvme: factor out namespace setup
> nvme: factor out pci setup
> nvme: factor out cmb setup
> nvme: factor out controller identify setup
>
> hw/block/nvme.c | 433 ++++++++++++++++++++++++------------------
> hw/block/nvme.h | 36 +++-
> hw/block/trace-events | 172 ++++++++---------
> include/block/nvme.h | 8 +
> 4 files changed, 372 insertions(+), 277 deletions(-)
>
> --
> 2.26.0
>
Hi Keith,
You have acked most of this previously, but not in it's most recent
state. Since a good bunch of the refactoring patches have been split up
and changed, only a small subset of the patches still carry your
Acked-by.
The 'nvme: fix pci doorbell size calculation' and 'nvme: add
max_ioqpairs device parameter' are new since your ack and given their
nature a review from you would be nice :)
Thanks,
Klaus
- Re: [PATCH v2 13/16] nvme: factor out namespace setup, (continued)
- [PATCH v2 15/16] nvme: factor out cmb setup, Klaus Jensen, 2020/04/15
- [PATCH v2 12/16] nvme: add namespace helpers, Klaus Jensen, 2020/04/15
- [PATCH v2 16/16] nvme: factor out controller identify setup, Klaus Jensen, 2020/04/15
- Re: [PATCH v2 00/16] nvme: refactoring and cleanups, no-reply, 2020/04/15
- Re: [PATCH v2 00/16] nvme: refactoring and cleanups,
Klaus Birkelund Jensen <=
- Re: [PATCH v2 00/16] nvme: refactoring and cleanups, Keith Busch, 2020/04/20
- Re: [PATCH v2 00/16] nvme: refactoring and cleanups, Maxim Levitsky, 2020/04/21