[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v25 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common ma
From: |
Peter Maydell |
Subject: |
Re: [PATCH v25 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro |
Date: |
Fri, 17 Apr 2020 14:15:33 +0100 |
On Fri, 10 Apr 2020 at 12:45, Dongjiu Geng <address@hidden> wrote:
>
> The little end UUID is used in many places, so make
> NVDIMM_UUID_LE to a common macro to convert the UUID
> to a little end array.
>
> Reviewed-by: Xiang Zheng <address@hidden>
> Signed-off-by: Dongjiu Geng <address@hidden>
> ---
> hw/acpi/nvdimm.c | 10 +++-------
> include/qemu/uuid.h | 9 +++++++++
> 2 files changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> index eb6a37b..a747c63 100644
> --- a/hw/acpi/nvdimm.c
> +++ b/hw/acpi/nvdimm.c
> @@ -27,6 +27,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/uuid.h"
> #include "hw/acpi/acpi.h"
> #include "hw/acpi/aml-build.h"
> #include "hw/acpi/bios-linker-loader.h"
> @@ -34,18 +35,13 @@
> #include "hw/mem/nvdimm.h"
> #include "qemu/nvdimm-utils.h"
>
> -#define NVDIMM_UUID_LE(a, b, c, d0, d1, d2, d3, d4, d5, d6, d7) \
> - { (a) & 0xff, ((a) >> 8) & 0xff, ((a) >> 16) & 0xff, ((a) >> 24) & 0xff, \
> - (b) & 0xff, ((b) >> 8) & 0xff, (c) & 0xff, ((c) >> 8) & 0xff, \
> - (d0), (d1), (d2), (d3), (d4), (d5), (d6), (d7) }
> -
> /*
> * define Byte Addressable Persistent Memory (PM) Region according to
> * ACPI 6.0: 5.2.25.1 System Physical Address Range Structure.
> */
> static const uint8_t nvdimm_nfit_spa_uuid[] =
> - NVDIMM_UUID_LE(0x66f0d379, 0xb4f3, 0x4074, 0xac, 0x43, 0x0d, 0x33,
> - 0x18, 0xb7, 0x8c, 0xdb);
> + UUID_LE(0x66f0d379, 0xb4f3, 0x4074, 0xac, 0x43, 0x0d, 0x33,
> + 0x18, 0xb7, 0x8c, 0xdb);
>
> /*
> * NVDIMM Firmware Interface Table
> diff --git a/include/qemu/uuid.h b/include/qemu/uuid.h
> index 129c45f..c55541b 100644
> --- a/include/qemu/uuid.h
> +++ b/include/qemu/uuid.h
> @@ -34,6 +34,15 @@ typedef struct {
> };
> } QemuUUID;
>
> +/**
> + * convert UUID to little-endian array
> + * The input parameter is the member of UUID
> + */
This isn't in the right form to be a proper doc-comment comment,
and it's too brief to really help somebody who doesn't already
know what the macro does.
The parameter names to the macro are still terrible, and
"member of UUID" doesn't help -- assuming you mean "members
of the QemuUUID struct, those are named 'time_low' , 'time_mid',
and so on, not this random selection of alphabetic and d0..d7.
> +#define UUID_LE(a, b, c, d0, d1, d2, d3, d4, d5, d6, d7) \
> + { (a) & 0xff, ((a) >> 8) & 0xff, ((a) >> 16) & 0xff, ((a) >> 24) & 0xff, \
> + (b) & 0xff, ((b) >> 8) & 0xff, (c) & 0xff, ((c) >> 8) & 0xff, \
> + (d0), (d1), (d2), (d3), (d4), (d5), (d6), (d7) }
> +
> #define UUID_FMT "%02hhx%02hhx%02hhx%02hhx-" \
> "%02hhx%02hhx-%02hhx%02hhx-" \
> "%02hhx%02hhx-" \
> --
> 1.8.3.1
thanks
-- PMM
- [PATCH v25 00/10] Add ARMv8 RAS virtualization support in QEMU, Dongjiu Geng, 2020/04/10
- [PATCH v25 10/10] MAINTAINERS: Add ACPI/HEST/GHES entries, Dongjiu Geng, 2020/04/10
- [PATCH v25 03/10] docs: APEI GHES generation and CPER record description, Dongjiu Geng, 2020/04/10
- [PATCH v25 07/10] KVM: Move hwpoison page related functions into kvm-all.c, Dongjiu Geng, 2020/04/10
- [PATCH v25 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro, Dongjiu Geng, 2020/04/10
- Re: [PATCH v25 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro,
Peter Maydell <=
- [PATCH v25 02/10] hw/arm/virt: Introduce a RAS machine option, Dongjiu Geng, 2020/04/10
- [PATCH v25 09/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM, Dongjiu Geng, 2020/04/10
- [PATCH v25 05/10] ACPI: Build Hardware Error Source Table, Dongjiu Geng, 2020/04/10
- [PATCH v25 06/10] ACPI: Record the Generic Error Status Block address, Dongjiu Geng, 2020/04/10
- [PATCH v25 04/10] ACPI: Build related register address fields via hardware error fw_cfg blob, Dongjiu Geng, 2020/04/10
- [PATCH v25 08/10] ACPI: Record Generic Error Status Block(GESB) table, Dongjiu Geng, 2020/04/10
- RE: [PATCH v25 00/10] Add ARMv8 RAS virtualization support in QEMU, gengdongjiu, 2020/04/16
- Message not available
- Re: [PATCH v25 00/10] Add ARMv8 RAS virtualization support in QEMU, Peter Maydell, 2020/04/17