qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-5.0?] target/ppc: Fix TCG temporary leaks in gen_slbia()


From: Cédric Le Goater
Subject: Re: [PATCH-for-5.0?] target/ppc: Fix TCG temporary leaks in gen_slbia()
Date: Fri, 17 Apr 2020 14:46:16 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 4/17/20 11:07 AM, Philippe Mathieu-Daudé wrote:
> This fixes:
> 
>   $ qemu-system-ppc64 \
>   -machine pseries-4.1 -cpu power9 \
>   -smp 4 -m 12G -accel tcg ...
>   ...
>   Quiescing Open Firmware ...
>   Booting Linux via __start() @ 0x0000000002000000 ...
>   Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
>   Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
>   Opcode 1f 12 0f 00 (7ce003e4) leaked temporaries
> 
> [*] https://www.mail-archive.com/address@hidden/msg05400.html
> 
> Fixes: 0418bf78fe8 ("Fix ISA v3.0 (POWER9) slbia implementation")
> Reported-by: Dennis Clarke <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Reviewed-by: Cédric Le Goater <address@hidden>

Thanks,

C.

> ---
>  target/ppc/translate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index b207fb5386..0136c7e3ff 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -5003,6 +5003,7 @@ static void gen_slbia(DisasContext *ctx)
>      CHK_SV;
>  
>      gen_helper_slbia(cpu_env, t0);
> +    tcg_temp_free_i32(t0);
>  #endif /* defined(CONFIG_USER_ONLY) */
>  }
>  
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]