qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/6] dwc-hsotg USB host controller emulation


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 4/6] dwc-hsotg USB host controller emulation
Date: Thu, 16 Apr 2020 18:30:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 4/16/20 5:47 PM, Peter Maydell wrote:
On Thu, 16 Apr 2020 at 16:45, Peter Maydell <address@hidden> wrote:

On Sun, 29 Mar 2020 at 00:18, Paul Zimmerman <address@hidden> wrote:

+    s->as = &address_space_memory;

Ideally this should be a device property. (hw/dma/pl080.c
has an example of how to declare a TYPE_MEMORY_REGION
property and then create an AddressSpace from it in
the realize method. hw/arm/versatilepb.c and hw/arm/mps2-tz.c
show the other end, using object_property_set_link() to pass
the appropriate MemoryRegion to the device before realizing it.)

On closer inspection you're already doing that with the dma_as/
dma_mr. What's this AddressSpace for if it's different?

s->as is not used, probably a leftover (s->dma_as is used).


thanks
-- PMM





reply via email to

[Prev in Thread] Current Thread [Next in Thread]