[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/6] scripts/coverity-scan: Add Docker support
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 6/6] scripts/coverity-scan: Add Docker support |
Date: |
Wed, 15 Apr 2020 13:27:16 +0100 |
On Tue, 14 Apr 2020 at 12:58, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 3/19/20 8:33 PM, Peter Maydell wrote:
> > + # TODO: This re-downloads the tools every time, rather than
> > + # caching and reusing the image produced with the downloaded tools.
> > + # Not sure why.
>
> I remember something similar when using -f and COPY.
>
> My guess is using -f somefile instead of a directory, then COPY from
> outside of the directory, the cache is invalidated (or not used). If the
> file copied and the Dockerfile are in the same directory, it works (for me).
The comment turns out to be not entirely accurate -- at least some
of the time it successfully skips re-doing the tools download;
but sometimes it doesn't and I'm not sure what triggers that.
> > + # TODO: how do you get 'docker build' to print the output of the
> > + # commands it is running to its stdout? This would be useful for debug.
>
> Maybe '--progress plain'?
Good find, I'll have to try that.
thanks
-- PMM