[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/16] nvme: factor out namespace setup
|
From: |
Klaus Birkelund Jensen |
|
Subject: |
Re: [PATCH 13/16] nvme: factor out namespace setup |
|
Date: |
Wed, 15 Apr 2020 12:59:42 +0200 |
On Apr 15 12:53, Klaus Birkelund Jensen wrote:
> On Apr 15 12:38, Philippe Mathieu-Daudé wrote:
> >
> > I'm not sure this line belong to this patch.
> >
>
> It does. It is already there in the middle of the realize function. It
> is moved to nvme_init_namespace as
>
> n->ns_size = bs_size;
>
> since only a single namespace can be configured anyway. I will remove
> the for-loop that initializes multiple namespaces as well.
I'm gonna backtrack on that. Removing that for loop is just noise I
think.
- Re: [PATCH 11/16] nvme: factor out block backend setup, (continued)
[PATCH 12/16] nvme: add namespace helpers, Klaus Jensen, 2020/04/15
[PATCH 14/16] nvme: factor out pci setup, Klaus Jensen, 2020/04/15
[PATCH 13/16] nvme: factor out namespace setup, Klaus Jensen, 2020/04/15
[PATCH 15/16] nvme: factor out cmb setup, Klaus Jensen, 2020/04/15
[PATCH 16/16] nvme: factor out controller identify setup, Klaus Jensen, 2020/04/15
Re: [PATCH 00/16] nvme: refactoring and cleanups, no-reply, 2020/04/15