Re: [PATCH v2 for-5.1 0/9] qemu-option: Fix corner cases and clean up

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 for-5.1 0/9] qemu-option: Fix corner cases and clean up
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3b33be5 qemu-img: Reject broken -o ""
7b5dadd qemu-img: Move is_valid_option_list() to qemu-img.c and rewrite
30bbe34 qemu-img: Factor out accumulate_options() helper
c2990e9 qemu-option: Avoid has_help_option() in qemu_opts_parse_noisily()
2f6d0e4 test-qemu-opts: Simplify test_has_help_option() after bug fix
6268d34 qemu-option: Fix has_help_option()'s sloppy parsing
9698bcc qemu-option: Fix sloppy recognition of "id=..." after ", , "
9537d23 qemu-options: Factor out get_opt_name_value() helper
0f6839c tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()

=== OUTPUT BEGIN ===
1/9 Checking commit 0f6839cdf754 (tests-qemu-opts: Cover has_help_option(), 
qemu_opt_has_help_opt())
WARNING: Block comments use a leading /* on a separate line
#42: FILE: tests/test-qemu-opts.c:752:
+        { "a,b,,help", false /* BUG */, true, true },

WARNING: Block comments use a leading /* on a separate line
#43: FILE: tests/test-qemu-opts.c:753:
+        { "a,b,,?", false /* BUG */, true, true },

total: 0 errors, 2 warnings, 56 lines checked

Patch 1/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/9 Checking commit 9537d23096a7 (qemu-options: Factor out get_opt_name_value() 
helper)
3/9 Checking commit 9698bcc1c1fe (qemu-option: Fix sloppy recognition of 
"id=..." after ", , ")
4/9 Checking commit 6268d3455410 (qemu-option: Fix has_help_option()'s sloppy 
parsing)
5/9 Checking commit 2f6d0e4867b6 (test-qemu-opts: Simplify 
test_has_help_option() after bug fix)
6/9 Checking commit c2990e93eb56 (qemu-option: Avoid has_help_option() in 
qemu_opts_parse_noisily())
7/9 Checking commit 30bbe34c8b6f (qemu-img: Factor out accumulate_options() 
helper)
8/9 Checking commit 7b5daddaec17 (qemu-img: Move is_valid_option_list() to 
qemu-img.c and rewrite)
ERROR: suspect code indent for conditional statements (4, 4)
#62: FILE: qemu-img.c:243:
+    for (i = len; i > 0 && optarg[i - 1] == ','; i--) {
+    }

total: 1 errors, 0 warnings, 67 lines checked

Patch 8/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/9 Checking commit 3b33be56023f (qemu-img: Reject broken -o "")
ERROR: trailing whitespace
#49: FILE: qemu-img.c:234:
+ * $

total: 1 errors, 0 warnings, 18 lines checked

Patch 9/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden