[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 16/17] tests/tcg: drop inferior.was_attached() test
From: |
Alex Bennée |
Subject: |
[PATCH v2 16/17] tests/tcg: drop inferior.was_attached() test |
Date: |
Tue, 14 Apr 2020 21:06:30 +0100 |
This test seems flaky and reports attachment even when we failed to
negotiate the architecture. However the fetching of the guest
architecture will fail tripping up the gdb AttributeError which will
trigger our early no error status exit from the test
Signed-off-by: Alex Bennée <address@hidden>
---
tests/tcg/aarch64/gdbstub/test-sve-ioctl.py | 3 ---
tests/tcg/aarch64/gdbstub/test-sve.py | 3 ---
2 files changed, 6 deletions(-)
diff --git a/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
b/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
index 984fbeb277e..5824abe09ac 100644
--- a/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
+++ b/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
@@ -58,9 +58,6 @@ def run_test():
#
try:
inferior = gdb.selected_inferior()
- if inferior.was_attached == False:
- print("SKIPPING (failed to attach)", file=sys.stderr)
- exit(0)
arch = inferior.architecture()
report(arch.name() == "aarch64", "connected to aarch64")
except (gdb.error, AttributeError):
diff --git a/tests/tcg/aarch64/gdbstub/test-sve.py
b/tests/tcg/aarch64/gdbstub/test-sve.py
index dbe7f2aa932..90201d80094 100644
--- a/tests/tcg/aarch64/gdbstub/test-sve.py
+++ b/tests/tcg/aarch64/gdbstub/test-sve.py
@@ -59,9 +59,6 @@ def run_test():
#
try:
inferior = gdb.selected_inferior()
- if inferior.was_attached == False:
- print("SKIPPING (failed to attach)", file=sys.stderr)
- exit(0)
arch = inferior.architecture()
report(arch.name() == "aarch64", "connected to aarch64")
except (gdb.error, AttributeError):
--
2.20.1
- [PATCH v2 06/17] tests/docker: add docs FEATURE flag and use for test-misc, (continued)
- [PATCH v2 06/17] tests/docker: add docs FEATURE flag and use for test-misc, Alex Bennée, 2020/04/14
- [PATCH v2 07/17] configure: redirect sphinx-build check to config.log, Alex Bennée, 2020/04/14
- [PATCH v2 05/17] linux-user/ppc: Fix padding in mcontext_t for ppc64, Alex Bennée, 2020/04/14
- [PATCH v2 08/17] configure: disable PIE for Windows builds, Alex Bennée, 2020/04/14
- [PATCH v2 12/17] gdbstub: Do not use memset() on GByteArray, Alex Bennée, 2020/04/14
- [PATCH v2 11/17] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb, Alex Bennée, 2020/04/14
- [PATCH v2 13/17] gdbstub: Introduce gdb_get_float32() to get 32-bit float registers, Alex Bennée, 2020/04/14
- [PATCH v2 09/17] linux-user: fix /proc/self/stat handling, Alex Bennée, 2020/04/14
- [PATCH v2 10/17] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray, Alex Bennée, 2020/04/14
- [PATCH v2 16/17] tests/tcg: drop inferior.was_attached() test,
Alex Bennée <=
- [PATCH v2 17/17] tests/tcg: add a multiarch linux-user gdb test, Alex Bennée, 2020/04/14
- [PATCH v2 15/17] target/m68k: hack around the FPU register support (HACK!), Alex Bennée, 2020/04/14
- [PATCH v2 14/17] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers, Alex Bennée, 2020/04/14
- Re: [PATCH v2 for 5.0-rc3 00/17] more randome fixes (user, pie, docker and gdbstub), no-reply, 2020/04/14