Re: cscope redundant chars

[Markus Armbruster]

Toe Dev <address@hidden> writes:

> add cscope phony(ctags have one) and remove redundancy
>
> diff --git a/Makefile b/Makefile
> index 84ef881600..9cf62532f9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1005,16 +1005,18 @@ ctags:
>         rm -f tags
>         find "$(SRC_PATH)" -name '*.[hc]' -exec ctags --append {} +
>
> +.PHONY: cscope
> +
> +cscope:
> +       rm -f cscope.*
> +       find $(SRC_PATH) -name "*.[chsS]" -print | sed 's,^\./,,' >
> "$(SRC_PATH)/cscope.files"
> +       cscope -b -q -k cscope.files
> +
>  .PHONY: TAGS
>  TAGS:
>         rm -f TAGS
>         find "$(SRC_PATH)" -name '*.[hc]' -exec etags --append {} +
>
> -cscope:
> -       rm -f "$(SRC_PATH)"/cscope.*
> -       find "$(SRC_PATH)/" -name "*.[chsS]" -print | sed 's,^\./,,' >
> "$(SRC_PATH)/cscope.files"
> -       cscope -b -i"$(SRC_PATH)/cscope.files"
> -

Can you explain why you drop $(SRC_PATH)/ before cscope.* and
cscope.files?

You also de-quote $(SRC_PATH).  Breaks when $(SRC_PATH) contains funny
characters like space.  I'm not having funny characters there is a good
idea, let alone that it works.  Still, I can't see why we should strip
quotes here.