[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 30/30] iotests: Add tests for qcow2 images with extended L
From: |
Max Reitz |
Subject: |
Re: [PATCH v4 30/30] iotests: Add tests for qcow2 images with extended L2 entries |
Date: |
Tue, 14 Apr 2020 12:14:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 13.04.20 19:16, Alberto Garcia wrote:
> On Thu 09 Apr 2020 02:22:37 PM CEST, Max Reitz wrote:
>>> + ### Write subcluster #31-#34 (cluster overlap) ###
>>
>> #31-#34, I think.
>
> That's what I wrote :-?
Errrrr #31-#33.
>>> + ### Partially zeroize an unallocated cluster (#3)
>>> + if [ "$use_backing_file" = "yes" ]; then
>>> + alloc="`seq 0 15`"; zero=""
>>
>> Isn’t this a TODO? (I.e., ideally we’d want the first 16 subclusters
>> to be zero, and the last 16 subclusters to be unallocated, right?)
>>
>> (I’m asking because you did raise a TODO for the “Zero subcluster #1”
>> test)
>
> Maybe, but I just implemented zeroize at the subcluster level :-) Wait
> for the next version of the series.
OK :)
Max
signature.asc
Description: OpenPGP digital signature