[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 7/8] memory: Do not allow direct write access to rom_device region
From: |
Paolo Bonzini |
Subject: |
[PULL 7/8] memory: Do not allow direct write access to rom_device regions |
Date: |
Sat, 11 Apr 2020 09:03:29 -0400 |
From: Alexander Duyck <address@hidden>
According to the documentation in memory.h a ROM memory region will be
backed by RAM for reads, but is supposed to go through a callback for
writes. Currently we were not checking for the existence of the rom_device
flag when determining if we could perform a direct write or not.
To correct that add a check to memory_region_is_direct so that if the
memory region has the rom_device flag set we will return false for all
checks where is_write is set.
Signed-off-by: Alexander Duyck <address@hidden>
Message-Id: <20200410034150.24738.98143.stgit@localhost.localdomain>
Signed-off-by: Paolo Bonzini <address@hidden>
---
include/exec/memory.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 1614d9a02c..e000bd2f97 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -2351,8 +2351,8 @@ void address_space_write_cached_slow(MemoryRegionCache
*cache,
static inline bool memory_access_is_direct(MemoryRegion *mr, bool is_write)
{
if (is_write) {
- return memory_region_is_ram(mr) &&
- !mr->readonly && !memory_region_is_ram_device(mr);
+ return memory_region_is_ram(mr) && !mr->readonly &&
+ !mr->rom_device && !memory_region_is_ram_device(mr);
} else {
return (memory_region_is_ram(mr) && !memory_region_is_ram_device(mr))
||
memory_region_is_romd(mr);
--
2.18.2
- [PULL 0/8] Misc patches for QEMU 5.0-rc3, Paolo Bonzini, 2020/04/11
- [PULL 1/8] piix: fix xenfv regression, add compat machine xenfv-4.2, Paolo Bonzini, 2020/04/11
- [PULL 2/8] oslib-posix: take lock before qemu_cond_broadcast, Paolo Bonzini, 2020/04/11
- [PULL 4/8] atomics: update documentation, Paolo Bonzini, 2020/04/11
- [PULL 6/8] vl.c: error out if -mem-path is used together with -M memory-backend, Paolo Bonzini, 2020/04/11
- [PULL 5/8] rcu: do not mention atomic_mb_read/set in documentation, Paolo Bonzini, 2020/04/11
- [PULL 8/8] module: increase dirs array size by one, Paolo Bonzini, 2020/04/11
- [PULL 7/8] memory: Do not allow direct write access to rom_device regions,
Paolo Bonzini <=
- [PULL 3/8] atomics: convert to reStructuredText, Paolo Bonzini, 2020/04/11
- Re: [PULL 0/8] Misc patches for QEMU 5.0-rc3, Peter Maydell, 2020/04/11
- Re: [PULL 0/8] Misc patches for QEMU 5.0-rc3, Igor Mammedov, 2020/04/14