[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unb
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb |
|
Date: |
Fri, 10 Apr 2020 07:44:15 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 4/9/20 2:15 PM, Alex Bennée wrote:
> From: Peter Xu <address@hidden>
>
> We should only pass in gdb_get_reg16() with the GByteArray* object
> itself, no need to shift. Without this patch, gdb remote attach will
> crash QEMU.
>
> Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
> Signed-off-by: Peter Xu <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> Message-Id: <address@hidden>
> ---
> target/i386/gdbstub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling, Richard Henderson, 2020/04/10
[PATCH v1 11/11] .travis.yml: Build OSX 10.14 with Xcode 10.0, Alex Bennée, 2020/04/09
Re: [PATCH for 5.0-rc3 v1 00/11] more random fixes, no-reply, 2020/04/09