[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH 2/2] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb |
|
Date: |
Thu, 9 Apr 2020 14:01:30 -0400 |
Hi, Phil,
On Thu, Apr 09, 2020 at 07:21:04PM +0200, Philippe Mathieu-Daudé wrote:
> On 4/9/20 6:49 PM, Peter Xu wrote:
> > We should only pass in gdb_get_reg16() with the GByteArray* object
> > itself, no need to shift. Without this patch, gdb remote attach will
> > crash QEMU.
>
> You are correct.
>
> Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
Oh I forgot to paste the fix line. However, is it b7b8756a9c
("target/i386: use gdb_get_reg helpers", 2020-03-17) instead?
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Thanks!
>
> Same problem in m68k_fpu_gdb_get_reg().
>
> TODO for 5.1, rename mem_buf -> array.
--
Peter Xu