[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.0] aio-posix: signal-proof fdmon-io_uring
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH for-5.0] aio-posix: signal-proof fdmon-io_uring |
Date: |
Thu, 9 Apr 2020 15:55:12 +0100 |
On Wed, Apr 08, 2020 at 10:11:39AM +0100, Stefan Hajnoczi wrote:
> The io_uring_enter(2) syscall returns with errno=EINTR when interrupted
> by a signal. Retry the syscall in this case.
>
> It's essential to do this in the io_uring_submit_and_wait() case. My
> interpretation of the Linux v5.5 io_uring_enter(2) code is that it
> shouldn't affect the io_uring_submit() case, but there is no guarantee
> this will always be the case. Let's check for -EINTR around both APIs.
>
> Note that the liburing APIs have -errno return values.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> util/fdmon-io_uring.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature