Re: [PATCH v17 RESUBMIT QEMU 0/3] virtio-balloon: add support for providing free page reporting

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/20200408194628.24143.51644.stgit@localhost.localdomain/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v17 RESUBMIT QEMU 0/3] virtio-balloon: add support for 
providing free page reporting
Message-id: 20200408194628.24143.51644.stgit@localhost.localdomain
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c1e1e4c virtio-balloon: Provide a interface for free page reporting
c3fc4c5 virtio-balloon: Add support for providing free page reports to host
3410f65 virtio-balloon: Implement support for page poison tracking feature

=== OUTPUT BEGIN ===
1/3 Checking commit 3410f6599211 (virtio-balloon: Implement support for page 
poison tracking feature)
ERROR: trailing whitespace
#68: FILE: hw/virtio/virtio-balloon.c:708:
+    dev->poison_val = virtio_vdev_has_feature(vdev, 
VIRTIO_BALLOON_F_PAGE_POISON) ? $

WARNING: line over 80 characters
#68: FILE: hw/virtio/virtio-balloon.c:708:
+    dev->poison_val = virtio_vdev_has_feature(vdev, 
VIRTIO_BALLOON_F_PAGE_POISON) ? 

total: 1 errors, 1 warnings, 76 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/3 Checking commit c3fc4c5a9fc3 (virtio-balloon: Add support for providing 
free page reports to host)
3/3 Checking commit c1e1e4c7f3d1 (virtio-balloon: Provide a interface for free 
page reporting)
ERROR: code indent should never use tabs
#36: FILE: hw/virtio/virtio-balloon.c:330:
+    ^Iunsigned int i;$

ERROR: braces {} are necessary for all arms of this statement
#45: FILE: hw/virtio/virtio-balloon.c:339:
+            if (qemu_balloon_is_inhibited() || dev->poison_val)
[...]

ERROR: braces {} are necessary for all arms of this statement
#52: FILE: hw/virtio/virtio-balloon.c:346:
+            if ((ram_offset | size) & (rb_page_size - 1))
[...]

total: 3 errors, 0 warnings, 84 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200408194628.24143.51644.stgit@localhost.localdomain/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden