Re: [PATCH] When updating the PFLASH file contents, we should check for a possible failure of blk_pwrite(). Similar to 3a68829 commit

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] When updating the PFLASH file contents, we should check for a 
possible failure of blk_pwrite(). Similar to 3a68829 commit
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
e2d6d6e When updating the PFLASH file contents, we should check for a possible 
failure of blk_pwrite(). Similar to 3a68829 commit

=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#27: FILE: hw/block/pflash_cfi01.c:410:
+^Iif (ret < 0) {$

ERROR: code indent should never use tabs
#50: FILE: hw/block/pflash_cfi02.c:404:
+^Iif (ret < 0) {$

ERROR: code indent should never use tabs
#51: FILE: hw/block/pflash_cfi02.c:405:
+^I    error_report("Could not update PFLASH: %s", strerror(-ret));$

total: 3 errors, 0 warnings, 36 lines checked

Commit e2d6d6e28daf (When updating the PFLASH file contents, we should check 
for a possible failure of blk_pwrite(). Similar to 3a68829 commit) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden