|
From: | Juan Quintela |
Subject: | Re: [PATCH-for-5.1 v2 51/54] migration/colo: Add missing error-propagation code |
Date: | Tue, 07 Apr 2020 09:10:28 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> wrote: > Running the coccinelle script produced: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \ > --keep-comments --smpl-spacing --dir . > HANDLING: ./migration/colo.c > [[manual check required: error_propagate() might be missing in > migrate_set_block_enabled() ./migration/colo.c:439:4]] > > Add the missing error_propagate() after review. > > Signed-off-by: Philippe Mathieu-Daudé <address@hidden> Reviewed-by: Juan Quintela <address@hidden> Once there, all other uses of local_error on that file looks correct, and rest of calls to migrate_set_block_enabled() in the rest of qemu looks right. Thanks, Juan.
[Prev in Thread] | Current Thread | [Next in Thread] |