[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] usb: Add read support for HCIVERSION register to XHCI
From: |
Andrew Jeffery |
Subject: |
Re: [PATCH v1] usb: Add read support for HCIVERSION register to XHCI |
Date: |
Fri, 03 Apr 2020 11:18:54 +1030 |
User-agent: |
Cyrus-JMAP/3.1.7-1080-gca5de7b-fmstable-20200402v5 |
On Wed, 1 Apr 2020, at 21:53, Cédric Le Goater wrote:
> Hello,
>
> On 3/31/20 1:02 PM, Philippe Mathieu-Daudé wrote:
> > On 3/31/20 11:57 AM, Cameron Esfahani wrote:
> >> Philippe -
> >> From what I've seen, access size has nothing to do with alignment.
> >
> > Yes, I was wondering if you were using unaligned accesses.
> >
> > I *think* the correct fix is in the "memory: Support unaligned accesses on
> > aligned-only models" patch from Andrew Jeffery:
> > https://www.mail-archive.com/address@hidden/msg461247.html
>
> Here is an updated version I have been keeping since :
>
>
> https://github.com/legoater/qemu/commit/d57ac950c4be47a2bafd6c6a96dec2922c2ecd65
>
> which breaks qtest :
>
> microbit-test.c:307:test_nrf51_gpio: assertion failed (actual ==
> 0x01): (0 == 1)
>
> I haven't had time to look at this closely but it would be nice to get this
> patch merged.
Second this! I never had the chance to circle back and fix it up.
Andrew