Re: [PATCH] hw/core: properly terminate loading .hex on EOF record

[Stefan Hajnoczi]

On Wed, Apr 01, 2020 at 08:38:49PM +0100, Alex Bennée wrote:
> The https://makecode.microbit.org/#editor generates slightly weird
> .hex files which work fine on a real microbit but causes QEMU to
> choke. The reason is extraneous data after the EOF record which causes
> the loader to attempt to write a bigger file than it should to the
> "rom". According to the HEX file spec an EOF really should be the last
> thing we process so lets do that.
> 
> Reported-by: Ursula Bennée <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>  hw/core/loader.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature