Re: [PATCH] ppc/pnv: Introduce common PNV_SETFIELD() and PNV_GETFIELD() macros

[David Gibson]

On Thu, Apr 02, 2020 at 08:41:24AM +0200, Cédric Le Goater wrote:
> On 4/2/20 2:31 AM, David Gibson wrote:
> > On Wed, Apr 01, 2020 at 05:26:33PM +0200, Cédric Le Goater wrote:
> >> Most of QEMU definitions of the register fields of the PowerNV machine
> >> come from skiboot and the models duplicate a set of macros for this
> >> purpose. Make them common under the pnv_utils.h file.
> >>
> >> Signed-off-by: Cédric Le Goater <address@hidden>
> > 
> > Hrm.  If we're touching these, would it make sense to rewrite them in
> > terms of the cross-qemu generic extract64() and deposit64()?
> 
> I won't do that because we will loose compatibility with skiboot.

Uh.. how so?

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature