[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 05/10] target/xtensa: add FIXME for translation memory leak
From: |
Alex Bennée |
Subject: |
[PATCH v2 05/10] target/xtensa: add FIXME for translation memory leak |
Date: |
Wed, 1 Apr 2020 10:47:54 +0100 |
Dynamically allocating a new structure within the DisasContext can
potentially leak as we can longjmp out of the translation loop (see
test_phys_mem). The proper fix would be to use static allocation
within the DisasContext but as the Xtensa translator imports it's code
from elsewhere I leave that as an exercise for the maintainer.
Signed-off-by: Alex Bennée <address@hidden>
Cc: Max Filippov <address@hidden>
---
target/xtensa/translate.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 8aa972cafdf..37f65b1f030 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -1174,6 +1174,11 @@ static void
xtensa_tr_init_disas_context(DisasContextBase *dcbase,
dc->callinc = ((tb_flags & XTENSA_TBFLAG_CALLINC_MASK) >>
XTENSA_TBFLAG_CALLINC_SHIFT);
+ /*
+ * FIXME: This will leak when a failed instruction load or similar
+ * event causes us to longjump out of the translation loop and
+ * hence not clean-up in xtensa_tr_tb_stop
+ */
if (dc->config->isa) {
dc->insnbuf = xtensa_insnbuf_alloc(dc->config->isa);
dc->slotbuf = xtensa_insnbuf_alloc(dc->config->isa);
--
2.20.1
- [PATCH for 5.0 v2 00/10] A selection of sanitiser fixes, Alex Bennée, 2020/04/01
- [PATCH v2 01/10] elf-ops: bail out if we have no function symbols, Alex Bennée, 2020/04/01
- [PATCH v2 03/10] tests/tcg: remove extraneous pasting macros, Alex Bennée, 2020/04/01
- [PATCH v2 02/10] linux-user: protect fcntl64 with an #ifdef, Alex Bennée, 2020/04/01
- [PATCH v2 04/10] linux-user: more debug for init_guest_space, Alex Bennée, 2020/04/01
- [PATCH v2 05/10] target/xtensa: add FIXME for translation memory leak,
Alex Bennée <=
- [PATCH v2 06/10] gdbstub: fix compiler complaining, Alex Bennée, 2020/04/01
- [PATCH v2 07/10] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Alex Bennée, 2020/04/01
- [PATCH v2 08/10] linux-user: factor out reading of /proc/self/maps, Alex Bennée, 2020/04/01
- [PATCH v2 09/10] linux-user: clean-up padding on /proc/self/maps, Alex Bennée, 2020/04/01
- [PATCH v2 10/10] linux-user: completely re-write init_guest_space, Alex Bennée, 2020/04/01