Re: [PATCH v2] configure: warn if not using a separate build directory

[Eric Blake]

On 3/31/20 11:16 AM, Markus Armbruster wrote:
> Daniel P. Berrangé <address@hidden> writes:
>
> > Running configure directly from the source directory is a build
> > configuration that will go away in future. It is also not currently
> > covered by any automated testing. Display a deprecation warning if
> > the user attempts to use an in-srcdir build setup, so that they are
> > aware that they're building QEMU in an undesirable manner.
> >
> > Signed-off-by: Daniel P. Berrangé <address@hidden>
> > ---

> > +if test "$in_srcdir" = "yes"; then
> > +    echo
> > +    echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED"
>
> I don't like shouted warnings, but it's consistent with what we have.

The grammar is also a bit awkward to parse; maybe:

support for building in the source directory is deprecated

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org