[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 13/14] iotests: Mark verify functions as private
From: |
Max Reitz |
Subject: |
Re: [PATCH v10 13/14] iotests: Mark verify functions as private |
Date: |
Tue, 31 Mar 2020 12:40:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 31.03.20 02:00, John Snow wrote:
> Mark the verify functions as "private" with a leading underscore, to
> discourage their use. Update type signatures while we're here.
>
> (Also, make pending patches not yet using the new entry points fail in a
> very obvious way.)
>
> Signed-off-by: John Snow <address@hidden>
> ---
> tests/qemu-iotests/iotests.py | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [PATCH v10 08/14] iotests: touch up log function signature, (continued)
- [PATCH v10 08/14] iotests: touch up log function signature, John Snow, 2020/03/30
- [PATCH v10 06/14] iotests: alphabetize standard imports, John Snow, 2020/03/30
- [PATCH v10 09/14] iotests: limit line length to 79 chars, John Snow, 2020/03/30
- [PATCH v10 05/14] iotests: add pylintrc file, John Snow, 2020/03/30
- [PATCH v10 07/14] iotests: drop pre-Python 3.4 compatibility code, John Snow, 2020/03/30
- [PATCH v10 10/14] iotests: add hmp helper with logging, John Snow, 2020/03/30
- [PATCH v10 13/14] iotests: Mark verify functions as private, John Snow, 2020/03/30
- Re: [PATCH v10 13/14] iotests: Mark verify functions as private,
Max Reitz <=
- [PATCH v10 01/14] iotests: do a light delinting, John Snow, 2020/03/30
- [PATCH v10 12/14] iotest 258: use script_main, John Snow, 2020/03/30
- [PATCH v10 11/14] iotests: add script_initialize, John Snow, 2020/03/30
- [PATCH v10 14/14] iotests: use python logging for iotests.log(), John Snow, 2020/03/30
- Re: [PATCH v10 00/14] iotests: use python logging, Kevin Wolf, 2020/03/31