qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 24/42] nvme: remove redundant has_sg member


From: Maxim Levitsky
Subject: Re: [PATCH v6 24/42] nvme: remove redundant has_sg member
Date: Tue, 31 Mar 2020 12:25:48 +0300

On Tue, 2020-03-31 at 07:44 +0200, Klaus Birkelund Jensen wrote:
> On Mar 25 12:45, Maxim Levitsky wrote:
> > On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote:
> > > From: Klaus Jensen <address@hidden>
> > > 
> > > Remove the has_sg member from NvmeRequest since it's redundant.
> > 
> > To be honest this patch also replaces the dma_acct_start with 
> > block_acct_start
> > which looks right to me, and IMHO its OK to have both in the same patch,
> > but that should be mentioned in the commit message
> > 
> 
> I pulled it to a separate patch :)

Cool. Thanks

> 
> > With this fixed,
> > Reviewed-by: Maxim Levitsky <address@hidden>
> > 
> 
> 

Best regards,
        Maxim Levitsky





reply via email to

[Prev in Thread] Current Thread [Next in Thread]