[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 05/42] nvme: use constant for identify data size
From: |
Klaus Birkelund Jensen |
Subject: |
Re: [PATCH v6 05/42] nvme: use constant for identify data size |
Date: |
Tue, 31 Mar 2020 07:38:45 +0200 |
On Mar 25 12:37, Maxim Levitsky wrote:
> On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote:
> > From: Klaus Jensen <address@hidden>
> >
> > Signed-off-by: Klaus Jensen <address@hidden>
> > ---
> > hw/block/nvme.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> > index 40cb176dea3c..f716f690a594 100644
> > --- a/hw/block/nvme.c
> > +++ b/hw/block/nvme.c
> > @@ -679,7 +679,7 @@ static uint16_t nvme_identify_ns(NvmeCtrl *n,
> > NvmeIdentify *c)
> >
> > static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeIdentify *c)
> > {
> > - static const int data_len = 4 * KiB;
> > + static const int data_len = NVME_IDENTIFY_DATA_SIZE;
> > uint32_t min_nsid = le32_to_cpu(c->nsid);
> > uint64_t prp1 = le64_to_cpu(c->prp1);
> > uint64_t prp2 = le64_to_cpu(c->prp2);
>
> I'll probably squash this with some other refactoring patch,
> but I absolutely don't mind leaving this as is.
> Fine grained patches never cause any harm.
>
Squashed into 06/42.
> Reviewed-by: Maxim Levitsky <address@hidden>
>
> Best regards,
> Maxim Levitsky
>
>
>
>
[PATCH v6 08/42] nvme: add support for the abort command, Klaus Jensen, 2020/03/16