qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-5.0?] decodetree: Use Python3 floor division operator


From: Aleksandar Markovic
Subject: Re: [PATCH-for-5.0?] decodetree: Use Python3 floor division operator
Date: Tue, 31 Mar 2020 01:28:29 +0200

20:47 Pon, 30.03.2020. Richard Henderson <address@hidden> је написао/ла:
>
> On 3/30/20 10:14 AM, Richard Henderson wrote:
> > On 3/30/20 5:13 AM, Philippe Mathieu-Daudé wrote:
> >> This script started using Python2, where the 'classic' division
> >> operator returns the floor result. In commit 3d004a371 we started
> >> to use Python3, where the division operator returns the float
> >> result ('true division').
> >> To keep the same behavior, use the 'floor division' operator "//"
> >> which returns the floor result.
> >>
> >> Fixes: 3d004a371
> >> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> >> ---
> >> We didn't notice it because only the RX port (which uses the
> >> --varinsnwidth option, and got merged very recently) triggers
> >> these problems.
> >> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> >> ---
> >>  scripts/decodetree.py | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >
> > Reviewed-by: Richard Henderson <address@hidden>
>
> Queued to tcg-next for 5.0.
>

Richard, great, could you please pick up the LMI patch from the other day together with this patch in your tcg-5.0 queue?

Yours, Aleksandar

>
> r~
>
>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]