|
From: | Zenghui Yu |
Subject: | Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests |
Date: | Mon, 30 Mar 2020 16:30:07 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 |
Hi Eric, On 2020/3/20 17:24, Eric Auger wrote:
+static void its_cmd_queue_init(void) +{ + unsigned long order = get_order(SZ_64K >> PAGE_SHIFT); + u64 cbaser; + + its_data.cmd_base = (void *)virt_to_phys(alloc_pages(order));
Shouldn't the cmd_base (and the cmd_write) be set as a GVA? Otherwise I think we will end-up with memory corruption when writing the command queue. But it seems that everything just works fine ... So I'm really confused here :-/
+ + cbaser = ((u64)its_data.cmd_base | (SZ_64K / SZ_4K - 1) | GITS_CBASER_VALID); + + writeq(cbaser, its_data.base + GITS_CBASER); + + its_data.cmd_write = its_data.cmd_base; + writeq(0, its_data.base + GITS_CWRITER); +}
Otherwise this looks good, Reviewed-by: Zenghui Yu <address@hidden> Thanks
[Prev in Thread] | Current Thread | [Next in Thread] |