Re: [PATCH v2] monitor/hmp-cmds: add units for migrate_parameters.

[maozy]

On 3/28/20 2:02 AM, Dr. David Alan Gilbert wrote:
> * Mao Zhongyi (address@hidden) wrote:
> > When running:
> > (qemu) info migrate_parameters
> > announce-initial: 50 ms
> > announce-max: 550 ms
> > announce-step: 100 ms
> > compress-wait-thread: on
> > ...
> > max-bandwidth: 33554432 bytes/second
> > downtime-limit: 300 milliseconds
> > x-checkpoint-delay: 20000
> > ...
> > xbzrle-cache-size: 67108864
> >
> > add units for the parameters 'x-checkpoint-delay' and
> > 'xbzrle-cache-size', it's easier to read, also move
> > milliseconds to ms to keep the same style.
> >
> > Signed-off-by: Mao Zhongyi <address@hidden>
>
> Thanks
>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>
> (info migrate could also be fixed, but that's a separate issue)

Yes, will fix it in a separated patch.

Thanks,
Mao
> > ---
> >   monitor/hmp-cmds.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> > index 2a900a528a..790fad3afe 100644
> > --- a/monitor/hmp-cmds.c
> > +++ b/monitor/hmp-cmds.c
> > @@ -436,11 +436,11 @@ void hmp_info_migrate_parameters(Monitor *mon, const 
> > QDict *qdict)
> >               MigrationParameter_str(MIGRATION_PARAMETER_MAX_BANDWIDTH),
> >               params->max_bandwidth);
> >           assert(params->has_downtime_limit);
> > -        monitor_printf(mon, "%s: %" PRIu64 " milliseconds\n",
> > +        monitor_printf(mon, "%s: %" PRIu64 " ms\n",
> >               MigrationParameter_str(MIGRATION_PARAMETER_DOWNTIME_LIMIT),
> >               params->downtime_limit);
> >           assert(params->has_x_checkpoint_delay);
> > -        monitor_printf(mon, "%s: %u\n",
> > +        monitor_printf(mon, "%s: %u ms\n",
> >               MigrationParameter_str(MIGRATION_PARAMETER_X_CHECKPOINT_DELAY),
> >               params->x_checkpoint_delay);
> >           assert(params->has_block_incremental);
> > @@ -453,7 +453,7 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict 
> > *qdict)
> >           monitor_printf(mon, "%s: %s\n",
> >               MigrationParameter_str(MIGRATION_PARAMETER_MULTIFD_COMPRESSION),
> >               MultiFDCompression_str(params->multifd_compression));
> > -        monitor_printf(mon, "%s: %" PRIu64 "\n",
> > +        monitor_printf(mon, "%s: %" PRIu64 " bytes\n",
> >               MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE),
> >               params->xbzrle_cache_size);
> >           monitor_printf(mon, "%s: %" PRIu64 "\n",
> > --
> > 2.17.1
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK