[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] virtio-iommu: delete vqs in unrealize to fix memleaks
|
From: |
Auger Eric |
|
Subject: |
Re: [PATCH 2/2] virtio-iommu: delete vqs in unrealize to fix memleaks |
|
Date: |
Fri, 27 Mar 2020 09:51:15 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
Hi Pan,
On 3/27/20 4:56 AM, Pan Nengyuan wrote:
> req_vq/event_vq forgot to free in unrealize(). Fix that.
>
> Signed-off-by: Pan Nengyuan <address@hidden>
> ---
> Cc: Eric Auger <address@hidden>
> ---
> hw/virtio/virtio-iommu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
> index 4cee8083bc..9d2ff0693c 100644
> --- a/hw/virtio/virtio-iommu.c
> +++ b/hw/virtio/virtio-iommu.c
> @@ -696,6 +696,8 @@ static void virtio_iommu_device_unrealize(DeviceState
> *dev, Error **errp)
> g_tree_destroy(s->domains);
> g_tree_destroy(s->endpoints);
>
> + virtio_delete_queue(s->req_vq);
> + virtio_delete_queue(s->event_vq);
> virtio_cleanup(vdev);
> }
>
>
thanks for fixing this.
Acked-by: Eric Auger <address@hidden>
Eric