Re: [PATCH-for-5.0 02/12] hw/arm/bcm2835_peripherals: Add missing error-propagation code

[Peter Maydell]

On Wed, 25 Mar 2020 at 19:18, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Patch created mechanically by running:
>
>   $ spatch \
>     --macro-file scripts/cocci-macro-file.h --include-headers \
>     --sp-file 
> scripts/coccinelle/object_property_missing_error_propagate.cocci \
>     --keep-comments --smpl-spacing --in-place --dir hw
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  hw/arm/bcm2835_peripherals.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c
> index edcaa4916d..a111e91069 100644
> --- a/hw/arm/bcm2835_peripherals.c
> +++ b/hw/arm/bcm2835_peripherals.c
> @@ -133,254 +133,262 @@ static void bcm2835_peripherals_init(Object *obj)
>  static void bcm2835_peripherals_realize(DeviceState *dev, Error **errp)
>  {
>      BCM2835PeripheralState *s = BCM2835_PERIPHERALS(dev);
>      Object *obj;
>      MemoryRegion *ram;
>      Error *err = NULL;
>      uint64_t ram_size, vcram_size;
>      int n;

Is there a reason this patch has such an enormous amount of
context around the changes it's making ? It looks like it's
quoting the entire function.

Anyway
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM