[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/2] util/bufferiszero: improve avx2 accelerator
From: |
Hu, Robert |
Subject: |
RE: [PATCH 2/2] util/bufferiszero: improve avx2 accelerator |
Date: |
Thu, 26 Mar 2020 02:09:57 +0000 |
(Don't know why my Linux-Evolution missed this mail.)
> -----Original Message-----
> From: Eric Blake <address@hidden>
> Sent: Wednesday, March 25, 2020 20:54
> To: Robert Hoo <address@hidden>; address@hidden;
> address@hidden; address@hidden
> Cc: Hu, Robert <address@hidden>
> Subject: Re: [PATCH 2/2] util/bufferiszero: improve avx2 accelerator
>
> On 3/25/20 1:50 AM, Robert Hoo wrote:
> > By increasing avx2 length_to_accel to 128, we can simplify its logic
> > and reduce a branch.
> >
> > The authorship of this patch actually belongs to Richard Henderson
> > <address@hidden>,
>
> Long line; it's nice to wrap commit messages around column 70 or so (because
> reading 'git log' in an 80-column window adds indentation).
>
[Hu, Robert]
I think I set my vim on wrap. This probably escaped by paste.
I ran checkpatch.pl on the patches before sending. It escaped check but didn't
escaped your eagle eye😊 Thank you.
> > I just fix a boudary case on his original patch.
>
> boundary
[Hu, Robert]
Emm... again spell error. Usually I would paste descriptions into some editors
with spell check, but forgot this time.
Vim doesn't have spell check I think. What editor would you suggest me to
integrate with git editing?
BTW, do I need to resend these 2 patches?
>
> >
> > Suggested-by: Richard Henderson <address@hidden>
> > Signed-off-by: Robert Hoo <address@hidden>
> > ---
> > util/bufferiszero.c | 26 +++++++++-----------------
> > 1 file changed, 9 insertions(+), 17 deletions(-)
> >
>
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization: qemu.org | libvirt.org