Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions

[Aleksandar Markovic]

12:47 Sre, 25.03.2020. Aleksandar Markovic <address@hidden> је написао/ла:
>
> 12:44 Sre, 25.03.2020. Aleksandar Markovic <address@hidden> је написао/ла:
> >
> > 16:59 Uto, 24.03.2020. Richard Henderson <address@hidden> је написао/ла:
> > >
> > > On 3/24/20 5:22 AM, Jiaxun Yang wrote:
> > > > Loongson multimedia condition instructions were previously implemented as
> > > > write 0 to rd due to lack of documentation. So I just confirmed with Loongson
> > > > about their encoding and implemented them correctly.
> > > >
> > > > Signed-off-by: Jiaxun Yang <address@hidden>
> > > > Acked-by: Huacai Chen <address@hidden>
> > > > ---
> > > > v1: Use deposit opreations according to Richard's suggestion.
> > > > ---
> > > >  target/mips/translate.c | 35 +++++++++++++++++++++++++++++++----
> > > >  1 file changed, 31 insertions(+), 4 deletions(-)
> > >
> > > Reviewed-by: Richard Henderson <address@hidden>
> > >
> >
> > I just have a couple of mon-essential suggestions wrt coding style, but since all that is really of very insignificant nauture, I wouldn't even mention them.
> >
> > Reviewed-by: Aleksandar Markovic <address@hidden>
> >
>
> Sorry, there was a typo. It should be:
>
> Reviewed-by: Aleksandar Markovic <aleksandar.qem address@hidden>
>
> ("u" instead of "i" in "qemi")
>

Another problem with text formatting on mobile phones, this line should be:

Reviewed-by: Aleksandar Markovic <address@hidden>

Hope this all right now.

Sorry about that.

> > May I ask you, Richard, to select this patch for your next TCG-for-5.0 queue, so that I don't go through a MIPS queue process for just a single patch?
> >
> > Thanks to all involved people!
> >
> > Aleksandar
> >
> > >
> > > r~