[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 3/4] qcow2: add zstd cluster compression
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH v8 3/4] qcow2: add zstd cluster compression |
|
Date: |
Mon, 23 Mar 2020 13:47:52 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 23 Mar 2020 11:20:42 AM CET, Denis Plotnikov wrote:
>> But consider corrupted image: it may contain any data. And we should
>> not crash because of it. So, we should return error here.
> If the image is corrupted we can't continue anyway. If we return -EIO
> on this condition, we need to do some work investigating what has
> happened.
Cannot you just mark the image as corrupted and return -EIO ? I also
don't think that we should crash QEMU because of malformed input data.
Berto
[PATCH v8 1/4] qcow2: introduce compression type feature, Denis Plotnikov, 2020/03/21