Re: [PATCH 00/13] microvm: add acpi support

[Michael S. Tsirkin]

On Thu, Mar 19, 2020 at 09:01:04AM +0100, Gerd Hoffmann wrote:
> I know that not supporting ACPI in microvm is intentional.  If you still
> don't want ACPI this is perfectly fine, you can use the usual -no-acpi
> switch to toggle ACPI support.
> 
> These are the advantages you are going to loose then:
> 
>   (1) virtio-mmio device discovery without command line hacks (tweaking
>       the command line is a problem when not using direct kernel boot).
>   (2) Better IO-APIC support, we can use IRQ lines 16-23.
>   (3) ACPI power button (aka powerdown request) works.
>   (4) machine poweroff (aka S5 state) works.

What is the cost though? How do boot times compare?

> Together with seabios patches for virtio-mmio support this allows to
> boot standard fedora images (cloud, coreos, workstation live) with the
> microvm machine type.
> 
> cheers,
>   Gerd
> 
> Gerd Hoffmann (13):
>   acpi: make build_madt() more generic.
>   acpi: factor out acpi_dsdt_add_fw_cfg()
>   microvm: add isa-acpi device
>   microvm: add minimal acpi support.
>   microvm: add acpi_dsdt_add_virtio() for x86
>   microvm: disable virtio-mmio cmdline hack
>   [testing] seabios: update submodule to experimental microvm branch
>   [testing] seabios: update config & build rules
>   [testing] seabios: update binaries to experimental microvm branch
>   microvm/acpi: add rtc
>   microvm/acpi: add serial
>   microvm: make virtio irq base runtime configurable
>   microvm/acpi: use GSI 16-23 for virtio
> 
>  include/hw/i386/microvm.h   |   8 +-
>  hw/acpi/isa-acpi.c          | 114 +++++++++++++++
>  hw/i386/acpi-build.c        | 278 +++++++++++++++++++++++++++++-------
>  hw/i386/microvm.c           |  32 +++--
>  hw/acpi/Makefile.objs       |   1 +
>  pc-bios/bios-256k.bin       | Bin 262144 -> 262144 bytes
>  pc-bios/bios-microvm.bin    | Bin 65536 -> 131072 bytes
>  pc-bios/bios.bin            | Bin 131072 -> 131072 bytes
>  roms/Makefile               |   5 +-
>  roms/config.seabios-128k    |   2 +
>  roms/config.seabios-microvm |  25 ++++
>  roms/seabios                |   2 +-
>  12 files changed, 403 insertions(+), 64 deletions(-)
>  create mode 100644 hw/acpi/isa-acpi.c
>  create mode 100644 roms/config.seabios-microvm
> 
> -- 
> 2.18.2