qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/6] linux-user/flatload.c: Use "" for include of QEMU hea


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 4/6] linux-user/flatload.c: Use "" for include of QEMU header target_flat.h
Date: Sun, 22 Mar 2020 11:41:43 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/19/20 8:33 PM, Peter Maydell wrote:
The target_flat.h file is a QEMU header, so we should include it using
quotes, not angle brackets.

Coverity otherwise is unable to find the header:

"../linux-user/flatload.c", line 40: error #1712: cannot open source file
           "target_flat.h"
   #include <target_flat.h>
                           ^

because the relevant directory is only on the -iquote path, not the -I path.

Signed-off-by: Peter Maydell <address@hidden>
---
I don't know why Coverity in particular has trouble here but
real compilers don't. Still, the "" is the right thing.
---
  linux-user/flatload.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/flatload.c b/linux-user/flatload.c
index 0122ab3afe6..66901f39cc5 100644
--- a/linux-user/flatload.c
+++ b/linux-user/flatload.c
@@ -37,7 +37,7 @@
#include "qemu.h"
  #include "flat.h"
-#include <target_flat.h>
+#include "target_flat.h"
//#define DEBUG

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]