Re: [PATCH] spapr: Fix memory leak in h_client_architecture_support()

[Philippe Mathieu-Daudé]

On 3/21/20 6:34 PM, Greg Kurz wrote:
> This is the only error path that needs to free the previously allocated
> ov1.
>
> Reported-by: Coverity (CID 1421924)
> Fixes: cbd0d7f36322 "spapr: Fail CAS if option vector table cannot be parsed"
> Signed-off-by: Greg Kurz <address@hidden>
> ---
>   hw/ppc/spapr_hcall.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index 40c86e91eb89..0d50fc911790 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -1726,6 +1726,7 @@ static target_ulong 
> h_client_architecture_support(PowerPCCPU *cpu,
>       }
>       ov5_guest = spapr_ovec_parse_vector(ov_table, 5);
>       if (!ov5_guest) {
> +        spapr_ovec_cleanup(ov1_guest);

Quicker than using g_autoptr(), so for 5.0:

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

>           warn_report("guest didn't provide option vector 5");
>           return H_PARAMETER;
>       }