Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro

[Michael S. Tsirkin]

On Wed, Mar 18, 2020 at 02:02:37PM +0100, Juan Quintela wrote:
> Yuri Benditovich <address@hidden> wrote:
> > Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is
> > 16-bit field.
> >
> > Signed-off-by: Yuri Benditovich <address@hidden>
> 
> Reviewed-by: Juan Quintela <address@hidden>
> 
> Same caveat about attribution to MST.
> 
> Once told tha, I don't understand why you are using a unit16_t.
> You define indirections_len as:
> 
> +    uint16_t indirections_len;
> 
> But its maximum value right now is:
> 
> +#define VIRTIO_NET_RSS_MAX_TABLE_LEN    128
> 
> So, are we planning to increase that value in the next future, or we
> just want to give enough space?
> 
> Later, Juan.

The max size according to spec is u16. Using that limits
the size and makes it forward compatible.